The Rounding Error
thedailywtf.com
At one point, someone noticed that some financial transactions weren't summing up correctly in the C# application Nancy supported. It didn't require Superman or a Peter Gibbons to figure out why: someone was using floating points for handling dollar amounts. That kicked off a big refactoring project to replace the usage of double types with decimal types. Everything seemed to go well, at least until there was a network hiccup and the application couldn't connect to the database. Let's see if you can figure out what happened:

The post body:

[…] big refactoring project to replace the usage of double types with decimal types. Everything seemed to go well, at least until there was a network hiccup and the application couldn’t connect to the database. Let’s see if you can figure out what happened:

MessageBox.Show("Please decimal check the connection details. Also check firewall settings (port 1433) and network connectivity.");

What a clbuttic mistake.

I don’t actually get the joke with clbuttic, though. 🤔

    • smeg@feddit.ukEnglish
      5·
      8 days ago

      A long time ago I worked on a project which had all the user-facing text strings in their own separate file (for ease of translation). I didn’t think much more of it at the time, but even if I was just rubber-stamping this PR then seeing that a code-only refactor was touching the strings file would raise an eyebrow.

      • grrgyle@slrpnk.netOP
        1·
        8 days ago

        That’s a good practice. Seems obvious now that you’ve mentioned it, actually, but I don’t think I’ve ever done it. Except maybe incidentally when building an i18n table.

  • taaz@biglemmowski.winEnglish
    15·
    8 days ago

    Someone did s/double/decimal/g (find ‘double’, replace by ‘decimal’) on the whole project.

    Please decimal check

    lol

    • grrgyle@slrpnk.netOP
      2·
      8 days ago

      This is why you manually check and confirm each replacement, as tedious as it is. 😔

  • 0x0@programming.dev
    12·
    8 days ago

    I don’t actually get the joke with clbuttic, though.

    Replacing “ass” everywhere with “butt”.

  • sik0fewl@lemmy.ca
    5·
    8 days ago

    This is weird… I had a dream last night where I was trying to decide whether to use float or BigDecimal (Java). Unfortunately, I don’t remember the scenario or what I decided on.

    I swear that not all my dreams are this mundane.

    • grrgyle@slrpnk.netOP
      2·
      8 days ago

      I didn’t realise they’d been around so long. An programmer mentioned the website on one of my podcasts as being a good example of learning from others’ mistakes.

      The RSS feed is very good, too. You get everything you need just from the description.