I’m working on a project that needs lots of toolbars on screen at once, even though not all of them will be used at the same time. So, I’m modelling this ‘foldable’ dock widget after what I remember Photoshop panels used to be like.

It’s a work in progress, but would like to hear constructive suggestions.

https://blocks.programming.dev/0101100101/42c5d67f86c049baa3500aa38e439f8a

  • 0101100101@programming.devOP
    link
    fedilink
    English
    arrow-up
    0
    ·
    11 days ago

    By embedding the class, creates a limitation that prevents abstractions or other implementations of each component. Imagine every suggestion in this conversation thread is another variation with a separate implementation.

    If the user wanted to create a new FoldableDockWidget with a different title bar, they’d extend the FoldableDockWidget class and override the Titlebar method in their extension of it. I understand your point, but isn’t it over optimisation?

    The widget class belongs to the FoldableDockWidget class until it doesn’t. Then a refactor is needed.

    One line of instantiating code. I can’t imagine where or how the custom title bar would be used outside of the Foldable Dock Widget class though. That’s probably the real reason why I made it a sub class. Not how I’d do it in other languages, but in Python? I’m trying it out!

    Hardwiring a particular implementation of the Windowing python wrapper is necessary. They have slightly different implementations. If something magically new comes along, then, the code is updated. Again, over optimisation here which is unnecessary.

    The code in the process guard is just sample code to demonstrate use of the class. No big deal. It’s separate to the class and not to be imported because… this is a gist of sample code!

    • logging_strict@programming.dev
      link
      fedilink
      arrow-up
      0
      ·
      edit-2
      10 days ago

      Think the quote is premature optimization is the root of all evil. Don’t know who came up with that famous expression.

      In the case of the code in the process guard, perhaps you are right.

      In the case of embedding a class within FoldableDockWidget, it’s simply a case of don’t do that, not optimization.

      Hardwiring a particular implementation of the Windowing python wrapper is necessary.

      qasync

      Python library for using asyncio in Qt-based applications

      ^^ is the package to support them all.

      This comes directly from an app i wrote,

      from qasync import (asyncSlot, QtWidgets, QtGui, QtCore, _make_signaller)

      Here is some code which deals with differences between implementations

      from qasync import (QtWidgets, QtCore, QtGui, QtModuleName)
      
      __all__ = ["QtportQAction", "QtportQScreen", "QtportQScreenImplementation"]
      
      try:
          QtportQAction = QtWidgets.QAction
      except AttributeError as e:
          #"PySide6", "PyQt6"
          QtportQAction = QtGui.QAction
      
      try:
          QtportQScreen = QtWidgets.QDesktopWidget
          QtportQScreenImplementation = "QDesktopWidget"
      except AttributeError as e:
          QtportQScreen = QtGui.QScreen
          QtportQScreenImplementation = "QScreen"
      

      So it can be done!

      In the case of this gist, it’s premature optimization. Generally it’s necessary cuz new implementations come along often.

      • 0101100101@programming.devOP
        link
        fedilink
        English
        arrow-up
        0
        ·
        10 days ago

        In the case of this gist, it’s premature optimization. Generally it’s necessary cuz new implementations come along often.

        That sounds terribly inexperienced. That’s exactly what updates to code are for. You cannot manage all kind of, sort of similar but different libraries with one code base. It would be horrific to even consider it.